Reader Revenue message on US front #12593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +12.3 kB (+1.37%) Total Size: 914 kB
ℹ️ View Unchanged
|
tomrf1
commented
Oct 21, 2024
| @@ -45,7 +45,8 @@ function transformChoiceCardsAmountsToProduct( | |||
| const useChoiceCards = ( | |||
| choiceCardAmounts: SelectedAmountsVariant | undefined, | |||
| countryCode: string | undefined, | |||
| content: BannerTextContent, | |||
There was a problem hiding this comment.
Small refactor here because now both the banner and the new front container use this hook.
github-actions
bot
removed
the
run_chromatic
DanielCliftonGuardian
approved these changes
Oct 21, 2024
| @@ -306,6 +307,33 @@ export const FrontLayout = ({ front, NAV }: Props) => { | |||
| return null; | |||
| } | |||
|
|
|||
| if (collection.displayName === 'US end-of-year 2024') { | |||
There was a problem hiding this comment.
Suggested change
| if (collection.displayName === 'US end-of-year 2024') { | |
| if (collection.displayName === 'US end-of-year 2024' && editionId === 'US') { |
There was a problem hiding this comment.
Good point, though it's the pageId we need to check. Have pushed a commit
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
github-actions
bot
removed
the
run_chromatic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds a new component for the upcoming US end-of-year "Moment". This component is rendered in a Front container. We use the name of the container ("US end-of-year 2024") to decide when to render it. This means a container will need to be created in the fronts tool with the correct name.
Why?
In the past we've used "Thrashers" to deploy this type of message to the fronts. However, thrashers are not suitable for rich/interactive components like this. This component needs to render a ticker (based on a fetch) and interactive choice cards.
It's now much easier to build this type of thing in DCR as islands, where the relevant source components etc exist. It's also easier to line it up with the columns of the fronts.
Screenshots
Wide:
Leftcol:
Desktop:
Tablet:
Mobile:
