-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fairground 🎡] Card Headline sizing refactor #12571
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dotcom-rendering
and removed
run_chromatic
Runs chromatic when label is applied
labels
Oct 17, 2024
Size Change: -360 B (-0.04%) Total Size: 911 kB
ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 17, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 17, 2024
abeddow91
force-pushed
the
ab/headline-size-refactor-2
branch
from
October 17, 2024 14:49
30adc47
to
d3b99da
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 17, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 17, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 17, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 17, 2024
abeddow91
added
run_chromatic
Runs chromatic when label is applied
and removed
run_chromatic
Runs chromatic when label is applied
labels
Oct 21, 2024
abeddow91
force-pushed
the
ab/headline-size-refactor-2
branch
from
October 21, 2024 09:22
61c144c
to
1aaa736
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 21, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 21, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 21, 2024
abeddow91
force-pushed
the
ab/headline-size-refactor-2
branch
from
October 24, 2024 11:31
97c891e
to
736cdd3
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 24, 2024
Seen on PROD (merged by @abeddow91 8 minutes and 47 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Refactors how card headline sizing works, replacing the existing size scale with a larger scale. This has required updating all elements that use card headline and mapping the exiting sizing to the new scale.
Why?
The card headline component and logic had become unwieldy and increasingly hard to maintain or amend. The fairground project has introduced several new headline sizes which need to be accounted for across breakpoints. This PR adds these sizes to the font scale. It also replaces the varoius breakpoint props ie "headlineSizeAtTablet" with a headlineSizes object that has a required desktop value and can optionally take several other breakpoints. Desktop is the default font setting and any other breakpoint provided will override desktop in the cascade.
NB - there is follow up work for this PR that has been left out so that we can ensure we are not affecting existing cards. This has been outlined here
https://trello.com/c/7cYBL0I9/645-headline-sizing-follow-up-work
Screenshots
For the most part, there are no visual changes as a consequence of this PR as we are swapping like for like. This PR does however, fix a long standing issue whereby mobile devices with a "small" headline were rendering in 14px rather than 17px.