-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AudioPlayer
component
#12549
Merged
Merged
Add AudioPlayer
component
#12549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sndrs
force-pushed
the
e2e/add-audio-player
branch
from
October 14, 2024 15:57
6715237
to
20357f7
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 14, 2024
Size Change: 0 B Total Size: 914 kB ℹ️ View Unchanged
|
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 15, 2024
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 21, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 21, 2024
sndrs
force-pushed
the
e2e/add-audio-player
branch
from
October 22, 2024 14:37
555ae58
to
54dd147
Compare
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 23, 2024
dotcom-rendering/src/components/AudioPlayer/components/Playback.tsx
Outdated
Show resolved
Hide resolved
…k.tsx Co-authored-by: Daniel Clifton <[email protected]>
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 24, 2024
arelra
reviewed
Oct 24, 2024
github-actions
bot
removed
the
run_chromatic
Runs chromatic when label is applied
label
Oct 24, 2024
oliverabrahams
approved these changes
Oct 24, 2024
arelra
reviewed
Oct 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @sndrs ! 🔊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds an
AudioPlayer
component that recreates the functionality of frontend's audio player.It doesn't copy over the fake waveform SVG from frontend, because I'm not sure what it adds 🙃
It does fix scrubbing and buffering display though, as a quid pro quo.
Why?
Recreates the frontend player so we can render audio pages in DCR (closes #12485).
Screenshots
Until
leftCol
leftCol
and above