-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi byline element #12496
Open
rhystmills
wants to merge
24
commits into
main
Choose a base branch
from
rm/add-multi-byline
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add multi byline element #12496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +51 B (+0.01%) Total Size: 933 kB ℹ️ View Unchanged
|
rebecca-thompson
force-pushed
the
rm/add-multi-byline
branch
from
October 24, 2024 13:21
6f2a23a
to
48839af
Compare
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This adds the rendering logic for the Multi-byline element.
This is a variant of the
List
element from CAPI, in addition to the Key Takeaways, Q&A and Mini Profiles elements, which are rendered by DCR.The designs for this element can be found here: https://www.figma.com/design/TK4X89VBAIZ65zmIqApOkI/Formats-%E2%80%94-Structured-elements?node-id=5-165675&t=Fm8oqMKrRoOKTHyp-1
Why?
MultiBylines
are one of a number of new structure articles formats that Content Production have been developing which needs to be supported by our website.Screenshots