Update Ophan to 2.2.5 #12479
Merged
Update Ophan to 2.2.5 #12479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: +60 B (+0.01%) Total Size: 917 kB ℹ️ View Unchanged
|
|
I think the failing Playwright test will fail since the 2.2.5 version of |
I hadn't got around to looking into this yet so thanks for the pointer 🙏 |
|
fyi you'll need to rebase following: #12480 |
jamesmockett
force-pushed
the
jm/ophan-2-2-5
branch
from
220a3b0
to
094463f
Compare
jamesmockett
force-pushed
the
jm/ophan-2-2-5
branch
2 times, most recently
from
4cc323e
to
f60c9dd
Compare
|
Given that this failed silently should we add an e2e test to capture when we should send Ophan events, similar to the paid content e2e test? EDIT: will pick this up as a follow up |
jamesmockett
force-pushed
the
jm/ophan-2-2-5
branch
from
f60c9dd
to
0c1ae0d
Compare
arelra
approved these changes
Oct 7, 2024
|
Seen on PROD (merged by @jamesmockett 9 minutes and 30 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates
@guardian/ophan-tracker-jsto2.2.5Why?
This resolves an issue with tracking on the
VeggieBurgermenu. A change in Ophan's behaviour to avoid tracking clicks on whitespace within containers meant that thedata-link-nameattribute would only track events when applied to a link element. (The burger menu is alabelelement withrole="button"applied.) This has now been expanded from links to all clickable elements.