Ophan tracker JS does its own types #11438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
what happen to those? are they dropped on the floor? do they make their way into the lakehouse?
mxdvl
commented
Jul 2, 2024
dotcom-rendering/src/components/ShowHideContainers.importable.tsx
Outdated
Show resolved
Hide resolved
dotcom-rendering/src/components/YoutubeBlockComponent.importable.tsx
Outdated
Show resolved
Hide resolved
INT -> International EUR -> Europe
|
Size Change: -31 B (0%) Total Size: 889 kB ℹ️ View Unchanged
|
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
jonflynng
reviewed
Jul 11, 2024
| @@ -108,6 +108,7 @@ export const buildBrazeMessaging = async ( | |||
| const sdkLoadTimeTaken = endPerformanceMeasure(); | |||
| const ophan = await getOphan(renderingTarget); | |||
| ophan.record({ | |||
| // @ts-expect-error -- is this event dropped by Ophan? | |||
There was a problem hiding this comment.
Maybe adjust these comments to state that these events are being dropped and add a link to this PR for further context or a note that other teams will remove it later on.
|
I notice that the type |
domlander
approved these changes
Jul 11, 2024
jonflynng
approved these changes
Jul 11, 2024
teams should remove the invalid calls to Ophan, when they are able to do so, as these events are being dropped by Ophan, having an invalid shape.
Unfortunately, it’s not straightforward as the |
github-actions
bot
removed
the
run_chromatic
|
Ophan are happy with the release. Follow-up required by various teams:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Bump
@guardian/ophan-tracker-jsto the latest version and use its exported types, which are now owned by the @guardian/ophan team rather than being declared in@guardian/libsWhy?
The team responsible for the data analysis is best placed to own the type declaration! We should see less errors and dropped events once this is in place.
Known issues
Potential risks
This being a key part of our analytics, we should be extra careful in releasing changes.