early return if we dont have cards to display (#12722)

guardian · Oct 30, 2024 · cfef984 · cfef984
1 parent 1e0d19e
commit cfef984
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/dotcom-rendering/src/components/FlexibleGeneral.tsx b/dotcom-rendering/src/components/FlexibleGeneral.tsx
@@ -332,6 +332,8 @@ export const StandardCardLayout = ({
 	absoluteServerTimes: boolean;
 	showImage?: boolean;
 }) => {
+	if (cards.length === 0) return null;
+
 	return (
 		<UL
 			direction="row"

diff --git a/dotcom-rendering/src/components/FlexibleSpecial.tsx b/dotcom-rendering/src/components/FlexibleSpecial.tsx
@@ -178,6 +178,7 @@ const TwoCardOrFourCardLayout = ({
 	absoluteServerTimes: boolean;
 	showImage?: boolean;
 }) => {
+	if (cards.length === 0) return null;
 	const hasTwoOrFewerCards = cards.length <= 2;
 	return (
 		<UL
@@ -242,15 +243,13 @@ export const FlexibleSpecial = ({
 				absoluteServerTimes={absoluteServerTimes}
 				imageLoading={imageLoading}
 			/>
-
 			<OneCardLayout
 				cards={splash}
 				containerPalette={containerPalette}
 				showAge={showAge}
 				absoluteServerTimes={absoluteServerTimes}
 				imageLoading={imageLoading}
 			/>
-
 			<TwoCardOrFourCardLayout
 				cards={cards}
 				containerPalette={containerPalette}