Skip to content

Commit

Permalink
rollback changes to layout as these are in a different PR
Browse files Browse the repository at this point in the history
  • Loading branch information
oliverabrahams committed Oct 24, 2024
1 parent 23cc773 commit 3664823
Showing 1 changed file with 2 additions and 37 deletions.
39 changes: 2 additions & 37 deletions dotcom-rendering/src/layouts/StandardLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ import { MostViewedFooterData } from '../components/MostViewedFooterData.importa
import { MostViewedFooterLayout } from '../components/MostViewedFooterLayout';
import { MostViewedRightWithAd } from '../components/MostViewedRightWithAd.importable';
import { OnwardsUpper } from '../components/OnwardsUpper.importable';
import { Picture } from '../components/Picture';
import { RightColumn } from '../components/RightColumn';
import { Section } from '../components/Section';
import { SlotBodyEnd } from '../components/SlotBodyEnd.importable';
Expand Down Expand Up @@ -121,7 +120,7 @@ const StandardGrid = ({
? css`
grid-template-areas:
'title border headline headline .'
'image border disclaimer disclaimer right-column'
'. border disclaimer disclaimer right-column'
'meta border media media right-column'
'meta border standfirst standfirst right-column'
'. border body body right-column'
Expand Down Expand Up @@ -164,7 +163,7 @@ const StandardGrid = ({
? css`
grid-template-areas:
'title border headline .'
'image border disclaimer right-column'
'. border disclaimer right-column'
'meta border media right-column'
'meta border standfirst right-column'
'meta border body right-column'
Expand Down Expand Up @@ -210,7 +209,6 @@ const StandardGrid = ({
'disclaimer right-column'
'media right-column'
'standfirst right-column'
'image right-column'
'meta right-column'
'body right-column'
'. right-column';
Expand Down Expand Up @@ -250,7 +248,6 @@ const StandardGrid = ({
'disclaimer'
'media'
'standfirst'
'image'
'meta'
'body';
`
Expand Down Expand Up @@ -290,7 +287,6 @@ const StandardGrid = ({
'disclaimer'
'media'
'standfirst'
'image'
'meta'
'body';
`
Expand Down Expand Up @@ -348,20 +344,6 @@ const stretchLines = css`
}
`;

const podcastResponsiveCoverImage = css`
img {
width: 140px;
height: 140px;
}
margin: 0.375rem 0 0.375rem 0;
${from.wide} {
img {
width: 219px;
height: 219px;
}
}
`;

const starWrapper = css`
background-color: ${themePalette('--star-rating-background')};
color: ${themePalette('--star-rating-fill')};
Expand Down Expand Up @@ -435,8 +417,6 @@ export const StandardLayout = (props: WebProps | AppProps) => {

const renderAds = isWeb && canRenderAds(article);

const seriesTag = article.tags.find((tag) => tag.type === 'Series');

return (
<>
{isWeb && (
Expand Down Expand Up @@ -756,21 +736,6 @@ export const StandardLayout = (props: WebProps | AppProps) => {
</>
)}
</GridItem>
{format.design === ArticleDesign.Audio && seriesTag && (
<GridItem area="image" element="aside">
<div css={podcastResponsiveCoverImage}>
<Picture
role={'podcastCover'}
format={format}
master={seriesTag.podcast?.image ?? ''}
alt={seriesTag.title}
height={1}
width={1}
loading="lazy"
/>
</div>
</GridItem>
)}
<GridItem area="body">
{isWeb && (
<Hide from="leftCol">
Expand Down

0 comments on commit 3664823

Please sign in to comment.