Upgrade to TypeScript 5.5 (#11895)

* chore: move to TypeScript 55 https://devblogs.microsoft.com/typescript/announcing-typescript-5-5/ * test: expect enum mismatch * bump type-fest to latest
guardian · Jul 16, 2024 · 0846e81 · 0846e81
1 parent a89d283
commit 0846e81
Show file tree

Hide file tree

Showing 5 changed files with 476 additions and 264 deletions.
diff --git a/apps-rendering/package.json b/apps-rendering/package.json
@@ -103,7 +103,7 @@
 		"ts-loader": "9.5.1",
 		"tslib": "2.6.2",
 		"tsx": "4.6.2",
-		"typescript": "5.3.3",
+		"typescript": "5.5.3",
 		"webpack": "5.91.0",
 		"webpack-cli": "5.1.4",
 		"webpack-dev-server": "5.0.4",

diff --git a/apps-rendering/src/video.test.ts b/apps-rendering/src/video.test.ts
@@ -31,6 +31,7 @@ describe('parseVideo', () => {
 			type: ElementType.VIDEO,
 			assets: [
 				{
+					// @ts-expect-error -- these enums are actually compatible
 					type: AssetType.VIDEO,
 				},
 			],

diff --git a/dotcom-rendering/package.json b/dotcom-rendering/package.json
@@ -185,8 +185,8 @@
 		"ts-unused-exports": "8.0.5",
 		"tslib": "2.6.2",
 		"tsx": "4.6.2",
-		"type-fest": "4.6.0",
-		"typescript": "5.3.3",
+		"type-fest": "4.21.0",
+		"typescript": "5.5.3",
 		"typescript-json-schema": "0.58.1",
 		"unified": "11.0.5",
 		"valibot": "0.28.1",

diff --git a/dotcom-rendering/src/components/PersonalityQuizAtom.importable.tsx b/dotcom-rendering/src/components/PersonalityQuizAtom.importable.tsx
@@ -58,7 +58,7 @@ export const findMostReferredToBucketId = ({
 
 	for (const answerFromQuestion of answersFromQuestion) {
 		for (const answerBucket of answerFromQuestion.answerBuckets) {
-			if (answerBucket in bucketCounter) {
+			if (typeof bucketCounter[answerBucket] === 'number') {
 				bucketCounter[answerBucket] += 1;
 			} else {
 				bucketCounter[answerBucket] = 1;