Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Crossword input for IMEs / Android native keyboard. #1902

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

oliverabrahams
Copy link
Contributor

What are you changing?

  • Adding an onInput event handler to the crossword cells. To remove or add letters if the onKeydown event doesn't have the required information.

Why?

@oliverabrahams oliverabrahams requested a review from a team as a code owner January 23, 2025 10:14
Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: da7de42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Jan 23, 2025
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Jan 23, 2025
Copy link
Contributor

@jamesmockett jamesmockett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👏

@oliverabrahams oliverabrahams merged commit 226926f into main Jan 23, 2025
21 checks passed
@oliverabrahams oliverabrahams deleted the oa/crossword-handle-keydown-android branch January 23, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants