Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme.md #1887

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Update readme.md #1887

merged 3 commits into from
Jan 13, 2025

Conversation

shtukas
Copy link
Contributor

@shtukas shtukas commented Jan 9, 2025

What are you changing?

Updating the readme because what to do wasn't obvious to me. Now it's more clear.

@shtukas shtukas requested a review from a team as a code owner January 9, 2025 17:01
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a88db24

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added 📦 npm Affects a @guardian package on NPM @guardian/prettier labels Jan 9, 2025
@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label Jan 13, 2025
@shtukas shtukas merged commit ad0d438 into main Jan 13, 2025
23 checks passed
@shtukas shtukas deleted the shtukas-patch-1-1 branch January 13, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sndrs sndrs sndrs approved these changes

Assignees
No one assigned
Labels
@guardian/prettier 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shtukas @sndrs @oliverabrahams