Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hooks and context for cleaner code #1791

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Use hooks and context for cleaner code #1791

merged 4 commits into from
Nov 18, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Nov 15, 2024

needs #1790

What are you changing?

  • moves progress management into its own useProgress
  • provides progress and theme via context

Why?

i think it's makes things cleaner...?

@sndrs sndrs requested a review from a team as a code owner November 15, 2024 19:05
Copy link

changeset-bot bot commented Nov 15, 2024

⚠️ No Changeset found

Latest commit: ba78310

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label Nov 15, 2024
@sndrs sndrs added this to the Decommission Frontend Rendering milestone Nov 15, 2024
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs self-assigned this Nov 15, 2024
@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label Nov 15, 2024
@sndrs sndrs force-pushed the sndrs/crossword/context branch from 872ec2d to b6141f6 Compare November 15, 2024 19:09
@sndrs sndrs force-pushed the sndrs/crossword/context branch from b6141f6 to 584afd7 Compare November 15, 2024 19:11
@sndrs sndrs force-pushed the sndrs/crossword/grouped branch from 653b828 to 054bd64 Compare November 18, 2024 11:00
Base automatically changed from sndrs/crossword/grouped to main November 18, 2024 11:37
@sndrs sndrs enabled auto-merge (squash) November 18, 2024 12:03
@sndrs sndrs force-pushed the sndrs/crossword/context branch from 261b6ad to ba78310 Compare November 18, 2024 12:07
@sndrs sndrs merged commit f7206bd into main Nov 18, 2024
21 of 22 checks passed
@sndrs sndrs deleted the sndrs/crossword/context branch November 18, 2024 12:09
This was referenced Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants