-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V3 — Update to node current LTS (20.12.2) and core dependencies #23
base: main
Are you sure you want to change the base?
Conversation
Ok, I think the workflow files need to be upgraded as well to run fine. |
This now depends on https://github.com/guardian/riffraff-platform/pull/120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We (me and @akash1810 ) tested this PR against galaxies, and found a few bits that are broken. Potentially there's some gaps in our CI here, but I think it makes sense to merge these in smaller chunks. We'll have another go at this later in the week.
@NovemberTang I think the main issue, was the same one I experienced on guardian/actions-read-private-repos#8. I will rebase and add missing bits. |
Regarding the changes of ef06d4c we move from |
I tested this on https://github.com/guardian/content-pipeline-docs/pull/10, but unfortunately the build failed:
|
What does this change?
The associated changes update the action to run on
node 20.12.2
as well as the core dependencies. Presented in a logical order:node
as version16
has reached end of life, and Github actions should be upgraded.guardian cdk
,typescript
,es-lint
to the latest compatible versionpackage-lock.json
As the result of those upgrade:
main
branch 🙀)guardian cdk
upgrade.How to test?
I think that once this branch build, I should be able to reference it in a existing action and verify that it works before we release a version
3
, but I am not certain.How can we measure success?