Skip to content

Commit

Permalink
Update use of download-artifact to v4
Browse files Browse the repository at this point in the history
Reading through the migration guides [for
download-artifact@v4](https://github.com/actions/download-artifact/blob/main/docs/MIGRATION.md)
and [for
upload-artifact@v4](https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md),
I don’t think we’re currently using any of the features of v3 that have
been removed in v4.

So I think just updating the version numbers should be sufficient.
  • Loading branch information
emdash-ie committed Jan 9, 2025
1 parent 020fb5c commit 90f8fc8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# @guardian/actions-static-site V2
# @guardian/actions-static-site V3

Action to provision and serve a static site with Google Auth and a custom
domain.
Expand Down Expand Up @@ -33,12 +33,12 @@ jobs:
# ... (Build your static site.)

# Then upload it as an artifact
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
path: my-site

# Then invoke this action (replacing app and domain)
- uses: guardian/actions-static-site@v2
- uses: guardian/actions-static-site@v3
with:
app: example
domain: example.gutools.co.uk
Expand Down
2 changes: 1 addition & 1 deletion action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ runs:
INPUT_DRYRUN: ${{ inputs.dryRun}}
INPUT_ACTIONS_RUNTIME_TOKEN: ${ github.token }

- uses: actions/download-artifact@v3
- uses: actions/download-artifact@v4
with:
name: ${{ inputs.artifact }}
path: site
Expand Down

0 comments on commit 90f8fc8

Please sign in to comment.