fix: Handle 429 responses from Chat API #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
added a commit
to guardian/prnouncer-config
that referenced
this pull request
Nov 5, 2024
Switch to the branch of guardian/actions-prnouncer#41 to test it.
The Google Chat API has a rate limit of 60 requests per minute. Sleep for 1.5 seconds after a 429 response. See https://developers.google.com/workspace/chat/limits.
akash1810
force-pushed
the
aa/chat-rate-limit
branch
from
6979a34
to
5ea82ec
Compare
akash1810
commented
Nov 5, 2024
src/google.rs
Outdated
| response.status() | ||
| ); | ||
| tokio::time::sleep(time::Duration::from_millis(1500)).await; | ||
| Box::pin(self.send(webhook_url, thread_key)).await |
There was a problem hiding this comment.
A terminating ; doesn't compile. I don't know Rust well enough to comment why - any help welcomed!
There was a problem hiding this comment.
Expressions without a semicolon return a value to the containing function or block. Expressions with a semicolon become statements and do not return a value.
shtukas
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Retry a Google Chat API request 1.5 seconds after receipt of a 429 response. This should help avoid the rate limit of this API (60 requests per minute).
Example output w/unhandled 429 responses
How to test
Following the README instructions:
main, observe a 429 response and program exitAlternatively, see guardian/prnouncer-config#71 and it's execution.
Fixes #40.