Skip to content

Commit

Permalink
Complete rewritte based on Celluloid
Browse files Browse the repository at this point in the history
Work in progress (doesn't work yet)
  • Loading branch information
thibaudgg committed Jun 11, 2013
1 parent d77b7a8 commit 7e0880d
Show file tree
Hide file tree
Showing 55 changed files with 3,791 additions and 3,862 deletions.
73 changes: 72 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,61 @@
## 1.2.0 - Jun 11, 2013

### Improvement

- [#124][] New `force_adapter` option, skip the `.listen_test` adapter test. ([@nicobrevin][])

## 1.1.6 - Jun 4, 2013

### Change

- [#120][] Warn when using relative_paths option when listening to multiple diretories. (reported by [@chriseppstein][], added by [@thibaudgg][])

## 1.1.5 - Jun 3, 2013

### Bug fix

- [#122][] Fix stop called very soon after starting. (reported by [@chriseppstein][], fixed by [@thibaudgg][])

## 1.1.4 - May 28, 2013

### Bug fix

- [#118][] Prevent polling just because the adapter gem was already required. ([@nilbus][])

## 1.1.3 - May 21, 2013

### Bug fix

- [#117][] Fix jruby error on Pathname#relative_path_from. ([@luikore][])

## 1.1.2 - May 14, 2013

### Bug fix

- [#115][] Fix for directory containing non-ascii chars. ([@luikore][])

## 1.1.1 - May 14, 2013

### Bug fix

- [#113][] Kill poller_thread before waiting for it to die. ([@antifuchs][])

## 1.1.0 - May 11, 2013

### Bug fix

- [#112][] Expand path for the given directories. (reported by [@nex3][], fixed by [@thibaudgg][])

### Change

- [#110][] Remove MultiListener deprecation warning message. (reported by [@nex3][], fixed by [@thibaudgg][])

## 1.0.3 - April 29, 2013

### Bug fix

- Rescue Errno::EBADF on sha1_checksum generation. ([@thibaudgg][])

## 1.0.2 - April 22, 2013

### Bug fix
Expand Down Expand Up @@ -250,15 +308,26 @@
[#98]: https://github.com/guard/listen/issues/98
[#103]: https://github.com/guard/listen/issues/103
[#104]: https://github.com/guard/listen/issues/104
[#110]: https://github.com/guard/listen/issues/110
[#112]: https://github.com/guard/listen/issues/112
[#113]: https://github.com/guard/listen/issues/113
[#115]: https://github.com/guard/listen/issues/115
[#117]: https://github.com/guard/listen/issues/117
[#118]: https://github.com/guard/listen/issues/118
[#120]: https://github.com/guard/listen/issues/120
[#122]: https://github.com/guard/listen/issues/122
[#124]: https://github.com/guard/listen/issues/124
[@Maher4Ever]: https://github.com/Maher4Ever
[@ahoward]: https://github.com/ahoward
[@akerbos]: https://github.com/akerbos
[@antifuchs]: https://github.com/antifuchs
[@chriseppstein]: https://github.com/chriseppstein
[@cobychapple]: https://github.com/cobychapple
[@daemonza]: https://github.com/daemonza
[@dkubb]: https://github.com/dkubb
[@ebroder]: https://github.com/ebroder
[@fny]: https://github.com/fny
[@luikore]: https://github.com/luikore
[@markiz]: https://github.com/markiz
[@martikaljuve]: https://github.com/martikaljuve
[@mat813]: https://github.com/mat813
Expand All @@ -267,6 +336,8 @@
[@napcs]: https://github.com/napcs
[@netzpirat]: https://github.com/netzpirat
[@nex3]: https://github.com/nex3
[@nicobrevin]: https://github.com/nicobrevin
[@nilbus]: https://github.com/nilbus
[@nysalor]: https://github.com/nysalor
[@piotr-sokolowski]: https://github.com/piotr-sokolowski
[@rymai]: https://github.com/rymai
Expand All @@ -276,4 +347,4 @@
[@textgoeshere]: https://github.com/textgoeshere
[@thibaudgg]: https://github.com/thibaudgg
[@vongruenigen]: https://github.com/vongruenigen
[@zanker]: https://github.com/zanker
[@zanker]: https://github.com/zanker
8 changes: 4 additions & 4 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ require 'rbconfig'
gem 'wdm', '>= 0.1.0' if RbConfig::CONFIG['target_os'] =~ /mswin|mingw/i

group :development do
gem 'guard-rspec'
gem 'yard'
gem 'redcarpet'
gem 'pimpmychangelog'
gem 'guard-rspec', require: false
gem 'yard', require: false
gem 'redcarpet', require: false
gem 'pimpmychangelog', require: false
end

group :test do
Expand Down
12 changes: 6 additions & 6 deletions Guardfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
guard :rspec, all_on_start: false, all_after_pass: false do
guard :rspec, bundler: false do
watch(%r{^spec/.+_spec\.rb$})
watch(%r{^lib/(.+)\.rb$}) { |m| "spec/#{m[1]}_spec.rb" }
watch('spec/support/adapter_helper.rb') { "spec/listen/adapters" }
watch('spec/support/listener_helper.rb') { "spec/listen/listener_spec.rb" }
watch('spec/support/fixtures_helper.rb') { "spec" }
watch('spec/spec_helper.rb') { "spec" }
watch(%r{^lib/(.+)\.rb$}) { |m| "spec/lib/#{m[1]}_spec.rb" }
watch('spec/support/adapter_helper.rb') { 'spec/lib/listen/adapter' }
watch('spec/support/listener_helper.rb') { 'spec/lib/listen/listener_spec.rb' }
watch('spec/support/fixtures_helper.rb') { 'spec' }
watch('spec/spec_helper.rb') { 'spec' }
end
Loading

11 comments on commit 7e0880d

@gregoriokusowski
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this commit was a WIP one, but the Listener blocking start! method was removed here, and isn't present on 2.0.0.
Will v 2.0.0 have this method?
Thanks!

@thibaudgg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah for me start! was confusing, so I removed it and I have no plan to re-add it. The new start method is non-blocking and if you want the process to block just call sleep after start, seems way simpler for me. Sounds good to you too?

@gregoriokusowski
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a bit confusing for me too. I asked this when I was investigating alexch/rerun#44 alexch/rerun#45. It's like I'm #lateonparty, heh.
I'll try to figure out if rerun really need this.

Thanks!

@alexch
Copy link
Contributor

@alexch alexch commented on 7e0880d Oct 16, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little rusty on why I used start!, but it's probably because I need to monitor and kill the listener thread (from a master thread in the same process, so sleep doesn't cut it).

I suppose I'll have to dig into Celluloid and the new Listen now to figure out why Rerun's tests are failing, and see if it's possible to use Listen v2.

@thibaudgg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What error do you see in rerun? Maybe it's the same issue that we have in spring: rails/spring#194

@alexch
Copy link
Contributor

@alexch alexch commented on 7e0880d Oct 16, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like the problem is that you removed the :filter option :-) ?!?

@thibaudgg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, use ignore option instead, it works the same way.

@alexch
Copy link
Contributor

@alexch alexch commented on 7e0880d Oct 16, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same only opposite! (It should have been named "include", not "filter".) It's still useful to have both lists. Not to mention it's difficult to reliably programatically invert a regular expression.

@thibaudgg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about a new only (instead of include) option?

@alexch
Copy link
Contributor

@alexch alexch commented on 7e0880d Oct 16, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only is a fine synonym. 👍

@thibaudgg
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll add that in the next days.

Please sign in to comment.