-
Notifications
You must be signed in to change notification settings - Fork 247
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Complete rewritte based on Celluloid
Work in progress (doesn't work yet)
- Loading branch information
Showing
55 changed files
with
3,791 additions
and
3,862 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
guard :rspec, all_on_start: false, all_after_pass: false do | ||
guard :rspec, bundler: false do | ||
watch(%r{^spec/.+_spec\.rb$}) | ||
watch(%r{^lib/(.+)\.rb$}) { |m| "spec/#{m[1]}_spec.rb" } | ||
watch('spec/support/adapter_helper.rb') { "spec/listen/adapters" } | ||
watch('spec/support/listener_helper.rb') { "spec/listen/listener_spec.rb" } | ||
watch('spec/support/fixtures_helper.rb') { "spec" } | ||
watch('spec/spec_helper.rb') { "spec" } | ||
watch(%r{^lib/(.+)\.rb$}) { |m| "spec/lib/#{m[1]}_spec.rb" } | ||
watch('spec/support/adapter_helper.rb') { 'spec/lib/listen/adapter' } | ||
watch('spec/support/listener_helper.rb') { 'spec/lib/listen/listener_spec.rb' } | ||
watch('spec/support/fixtures_helper.rb') { 'spec' } | ||
watch('spec/spec_helper.rb') { 'spec' } | ||
end |
Oops, something went wrong.
7e0880d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this commit was a WIP one, but the Listener blocking
start!
method was removed here, and isn't present on 2.0.0.Will v 2.0.0 have this method?
Thanks!
7e0880d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah for me
start!
was confusing, so I removed it and I have no plan to re-add it. The newstart
method is non-blocking and if you want the process to block just callsleep
afterstart
, seems way simpler for me. Sounds good to you too?7e0880d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a bit confusing for me too. I asked this when I was investigating alexch/rerun#44 alexch/rerun#45. It's like I'm #lateonparty, heh.
I'll try to figure out if rerun really need this.
Thanks!
7e0880d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little rusty on why I used
start!
, but it's probably because I need to monitor and kill the listener thread (from a master thread in the same process, sosleep
doesn't cut it).I suppose I'll have to dig into Celluloid and the new Listen now to figure out why Rerun's tests are failing, and see if it's possible to use Listen v2.
7e0880d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What error do you see in rerun? Maybe it's the same issue that we have in spring: rails/spring#194
7e0880d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it looks like the problem is that you removed the :filter option :-) ?!?
7e0880d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, use
ignore
option instead, it works the same way.7e0880d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same only opposite! (It should have been named "include", not "filter".) It's still useful to have both lists. Not to mention it's difficult to reliably programatically invert a regular expression.
7e0880d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about a new
only
(instead ofinclude
) option?7e0880d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only
is a fine synonym. 👍7e0880d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I'll add that in the next days.