Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unique accessor bug #19

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix unique accessor bug #19

wants to merge 8 commits into from

Commits on May 17, 2019

  1. Rename user.user_name to user.un but keep the accessor 

    Note that tests still pass with this change.
    @robrwo
    robrwo committed May 17, 2019
    Configuration menu
    Copy the full SHA
    352c175 View commit details
    Browse the repository at this point in the history

  2. Make user_name unique 

    This causes tests to fail (which is what we want, before we fix
this bug).
    @robrwo
    robrwo committed May 17, 2019
    Configuration menu
    Copy the full SHA
    bff291b View commit details
    Browse the repository at this point in the history

  3. Revert "Rename user.user_name to user.un but keep the accessor" 

    This reverts commit e4d66f53b21ce19466769cc067cc9eeaaf34a639.

Note that the tests pass again.
    @robrwo
    robrwo committed May 17, 2019
    Configuration menu
    Copy the full SHA
    664199c View commit details
    Browse the repository at this point in the history

  4. Rename user.user_name to user.un but keep the accessor (redo) 

    This undoes the previous revert.
    @robrwo
    robrwo committed May 17, 2019
    Configuration menu
    Copy the full SHA
    a3e393d View commit details
    Browse the repository at this point in the history

  5. Add _accessor_aliases attribute 

    We need the ability to look up original column names from the
accessor names. This allows the information to be cached for
a form.
    @robrwo
    robrwo committed May 17, 2019
    Configuration menu
    Copy the full SHA
    85518bb View commit details
    Browse the repository at this point in the history

  6. Add List::Util 1.29 as a prerequisite for pairmap function

    @robrwo
    robrwo committed May 17, 2019
    Configuration menu
    Copy the full SHA
    03794ab View commit details
    Browse the repository at this point in the history

  7. Look up column name from accessor 

    This fixes gshank#18 by using the column name instead of the accessor
in the search condition.
    @robrwo
    robrwo committed May 17, 2019
    Configuration menu
    Copy the full SHA
    7b223ca View commit details
    Browse the repository at this point in the history

  8. Add line to Changes

    @robrwo
    robrwo committed May 17, 2019
    Configuration menu
    Copy the full SHA
    4cb2601 View commit details
    Browse the repository at this point in the history