-
Notifications
You must be signed in to change notification settings - Fork 349
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Files created are logged on verbose
- Loading branch information
Crisci, Fabio | Piuccio | TRVDD
committed
Jul 9, 2014
1 parent
eb9e74d
commit 4944e2c
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4944e2c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm considering doing a PR that adds an option that outputs the maxmin result to log instead of requiring --verbose to be able to see the output. @piuccio, what would your preference on a default for that option be?
4944e2c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @roncli
Everything started from gruntjs/grunt-contrib-imagemin#236 and #75, initially the idea was to keep the default behavior and add a
silent: true
option to usegrunt.verbose
instead ofgrunt.log
. You can check the discussion (short) of that PR.I'm fine reverting to the default behavior as long as there's an option to make it silent, I have way too many files in my project.
Let's see what @sindresorhus has to say on this.
4944e2c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, not interested in more options.
4944e2c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change appears to be the root cause of issue #254, bringing the documentation and user expectations out of sync with the code.