Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow subscript loader to work on unpacked extension #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tumpio
Copy link
Contributor

@tumpio tumpio commented Nov 16, 2015

Sub script loading did not work on unpacked extension.

@grssam
Copy link
Owner

grssam commented Jan 10, 2016

Why will you unpack it? This extension is supposed to work as packed extension only.

@tumpio
Copy link
Contributor Author

tumpio commented Jan 10, 2016

I unpacked it so that I could modify it and test it at the same time while it is installed.

How are you doing it?

@wagnerand
Copy link

https://developer.mozilla.org/en-US/Add-ons/Setting_up_extension_development_environment#Firefox_extension_proxy_file

Nevertheless, that patch makes sense. You shouldn't have to fiddle with directories and and URIs (especially involving jar files.)

You shouldn't use .jar files anymore anyway, as the extra layer of compression actually reduces performance.

@tumpio
Copy link
Contributor Author

tumpio commented Jan 27, 2016

Thank you @wagnerand ! 👍

@tumpio tumpio closed this Jan 27, 2016
@tumpio
Copy link
Contributor Author

tumpio commented Jan 27, 2016

Well I leave it open then, @scrapmac can decide if you want it.

@tumpio tumpio reopened this Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants