Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proto-google-common-protos to 2.48.0 #11650

Closed
wants to merge 1 commit into from
Closed

Conversation

xxzgc
Copy link

@xxzgc xxzgc commented Oct 29, 2024

Update proto-google-common-protos to the recent version.
It aligns the underlying protobuf-java version with the one that grpc-protobuf depends on.

It should make maven-enforcer-plugin happy in the projects that use it:

[ERROR] Dependency convergence error for com.google.protobuf:protobuf-java:jar:3.25.5 paths to dependency are:
[ERROR] +-snip:0.0.1-SNAPSHOT
[ERROR]   +-io.grpc:grpc-protobuf:jar:1.68.1:compile
[ERROR]     +-com.google.protobuf:protobuf-java:jar:3.25.5:compile
[ERROR] and
[ERROR] +-snip:0.0.1-SNAPSHOT
[ERROR]   +-io.grpc:grpc-protobuf:jar:1.68.1:compile
[ERROR]     +-com.google.api.grpc:proto-google-common-protos:jar:2.41.0:compile
[ERROR]       +-com.google.protobuf:protobuf-java:jar:3.25.3:compile

To align the underlying protobuf-java version 
with the one that grpc-protobuf depends on
Copy link

CLA Not Signed

@ejona86
Copy link
Member

ejona86 commented Oct 29, 2024

We don't support dependency convergence. It is a fool's errand and dangerous because it requires heavy use of <exclude>. We recommend requireUpperBoundDeps instead.

We should be upgrading proto-google-common-protos for the next release, but nothing will guarantee dependency convergence.

@ejona86
Copy link
Member

ejona86 commented Nov 1, 2024

#11655 upgraded this dependency.

@ejona86 ejona86 closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants