Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/internal/xdsclient: Add counter metrics for valid and invalid resource updates #8038

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Jan 24, 2025

This PR adds counter metrics for the xDS Client, and unit tests. E2E tests still need to be written.

The gauge metrics are blocked on adding support for asynchronous gauges, and we also should move our synchronous gauges in RLS to asynchronous.

RELEASE NOTES:

  • xds/internal/xdsclient: Add counter metrics for valid and invalid resource updates

@zasweq zasweq requested a review from dfawley January 24, 2025 22:21
@zasweq zasweq added the Type: Feature New features or improvements in behavior label Jan 24, 2025
@zasweq zasweq added this to the 1.71 Release milestone Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 91.48936% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.19%. Comparing base (2fd426d) to head (23257e2).

Files with missing lines Patch % Lines
internal/stats/metrics_recorder_list.go 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8038      +/-   ##
==========================================
+ Coverage   82.17%   82.19%   +0.02%     
==========================================
  Files         383      383              
  Lines       38776    38807      +31     
==========================================
+ Hits        31864    31899      +35     
+ Misses       5585     5580       -5     
- Partials     1327     1328       +1     
Files with missing lines Coverage Δ
resolver/resolver.go 100.00% <ø> (ø)
resolver_wrapper.go 84.29% <100.00%> (+0.13%) ⬆️
server.go 82.35% <100.00%> (-0.20%) ⬇️
xds/internal/resolver/xds_resolver.go 79.04% <100.00%> (+0.38%) ⬆️
xds/internal/xdsclient/authority.go 77.11% <100.00%> (+0.24%) ⬆️
xds/internal/xdsclient/clientimpl.go 80.81% <100.00%> (+0.48%) ⬆️
xds/internal/xdsclient/pool.go 81.11% <100.00%> (+0.65%) ⬆️
xds/server.go 82.42% <100.00%> (+0.21%) ⬆️
internal/stats/metrics_recorder_list.go 91.48% <20.00%> (-8.52%) ⬇️

... and 17 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants