Date time and null strings fix #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TValueNull.ToString returns '' instead of 'null' - which is the more delphi way to handle missing fields and empty strings. besides, it could be confused with the string having a content of "null" Grijjy.Bson.Serialization.pas: the ISO8601ToDate() requires a "T" to separate the date part from the time part
TgoBsonSerializer.DeserializeString(): do not be so strict with the type casts. We can cast a int to a string - no problems. this can happen if the REST endpoint changed a field from string to integer, but the delphi class/record did not reflect those changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the following changes, you might be interested in:
Grijjy.Bson.Serialization.pas
TgoBsonSerializer.DeserializeString(): do not be so strict with the type casts. We can cast a int to a string - no problems.
this can happen if the REST endpoint changed a field from string to integer, but the delphi class/record did not reflect those changes.
Grijjy.Bson.pas:
TValueNull.ToString
returns '' instead of 'null' - which is the more delphi way to handle missing fields and empty strings. besides, it could be confused with the string having a content of "null"
Grijjy.Bson.Serialization.pas:
the ISO8601ToDate() requires a "T" to separate the date part from the time part