Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seconds to timestamp #452

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

graial
Copy link

@graial graial commented Nov 13, 2023

Needed seconds on my timestamps so added a set of functions.

The tz in src/ExFatLib/ExFatFilePrint.cpp is a magic number and I wasnt sure how you'd want to handle it within the library.

Not sure if you'd want to incorporate this or not. It's my first time attempting a pull request.

Cheers

@greiman
Copy link
Owner

greiman commented Nov 13, 2023

When I developed exFAT I started developing more data/time/time-zone functions. I finally decided to only provide the simple ones that were in FAT16/FAT32. These are also in FsFat. So for now I won't use this pull.

For future reference, I only add bug fixes to the release version of SdFat. New features go in SdFat-beta. I only update SdFat once or twice a year to avoid forcing users to install new versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants