Changes from second round of revisions #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jjc2718
commented
Sep 2, 2024
jjc2718
commented
- Add CNV analysis from reviewer response as a supplementary note/figure, and update main text
- Add model selection feature count analysis as a figure and update main text
- Add some context to intro/conclusion distinguishing ML/statistics studies of model complexity from current practice in genomics
cgreene
approved these changes
Sep 3, 2024
Co-authored-by: Casey Greene <[email protected]>
Co-authored-by: Casey Greene <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
[ci skip] This build is based on a8303ac. This commit was created by the following CI build and job: https://github.com/greenelab/generalization-manuscript/commit/a8303ac4ae8d758f49be984d62e9a51a02f2a31e/checks https://github.com/greenelab/generalization-manuscript/actions/runs/10782679583
github-actions bot
pushed a commit
that referenced
this pull request
Sep 9, 2024
[ci skip] This build is based on a8303ac. This commit was created by the following CI build and job: https://github.com/greenelab/generalization-manuscript/commit/a8303ac4ae8d758f49be984d62e9a51a02f2a31e/checks https://github.com/greenelab/generalization-manuscript/actions/runs/10782679583
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.