Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Fix NASL coding style output of deprecate VT plugin. Adjust test. #781

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Jan 10, 2025

What

The plugin had created a coding style like e.g.:

  script_tag(name:"deprecated", value:TRUE);

exit(0);
}

exit(66);

and had missed to indent the exit(0); by two spaces. This is fixed now.

Why

Have correct coding style / indentation in the NASL code

References

greenbone/vulnerability-tests#15425 (Fixing all existing VTs which had that missing indentation originating from the previous version of this plugin)

Checklist

  • Tests

@cfi-gb cfi-gb requested a review from a team as a code owner January 10, 2025 08:52
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA a577f89.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

Conventional Commits Report

Type Number
Changed 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.72%. Comparing base (d8a1a6d) to head (a577f89).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #781   +/-   ##
=======================================
  Coverage   79.72%   79.72%           
=======================================
  Files          87       87           
  Lines        3009     3009           
  Branches      584      584           
=======================================
  Hits         2399     2399           
  Misses        462      462           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant