Get view names along with tables

great_expectations_cloud/agent/actions/draft_datasource_config_action.py

@@ -60,7 +60,7 @@ def check_draft_datasource_config(
         datasource.test_connection(test_assets=True)  # raises `TestConnectionError` on failure
 
         if isinstance(datasource, SQLDatasource):
-            table_names = self._get_table_names(datasource=datasource)
+            table_names = self._get_table_names(datasource=datasource, include_views=True)
             self._update_table_names_list(config_id=event.config_id, table_names=table_names)
 
         return ActionResult(
@@ -69,9 +69,12 @@ def check_draft_datasource_config(
             created_resources=[],
         )
 
-    def _get_table_names(self, datasource: Datasource) -> list[str]:
+    def _get_table_names(self, datasource: Datasource, *, include_views: bool) -> list[str]:
         inspector: Inspector = inspect(datasource.get_engine())
-        return inspector.get_table_names()
+        names: list[str] = inspector.get_table_names()
+        if include_views:
+            names.extend(inspector.get_view_names())
+        return names
 
     def _update_table_names_list(self, config_id: UUID, table_names: list[str]) -> None:
         with create_session(access_token=self._auth_key) as session:

great_expectations_cloud/agent/actions/list_table_names.py

@@ -22,6 +22,8 @@
 
 
 class ListTableNamesAction(AgentAction[ListTableNamesEvent]):
+    """Return a list of the current table names (and views) for a given SQL based Datasource using the sqlalchemy inspector."""
+
     # TODO: New actions need to be created that are compatible with GX v1 and registered for v1.
     #  This action is registered for v0, see register_event_action()
 
@@ -36,6 +38,8 @@ def run(self, event: ListTableNamesEvent, id: str) -> ActionResult:
 
         inspector: Inspector = inspect(datasource.get_engine())
         table_names: list[str] = inspector.get_table_names()
+        # consider views as well
+        table_names.extend(inspector.get_view_names())
 
         self._add_or_update_table_names_list(
             datasource_id=str(datasource.id), table_names=table_names

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "great_expectations_cloud"
-version = "20241017.0.dev1"
+version = "20241021.0.dev0"
 description = "Great Expectations Cloud"
 authors = ["The Great Expectations Team <[email protected]>"]
 repository = "https://github.com/great-expectations/cloud"

tests/agent/actions/test_draft_datasource_config.py

@@ -170,7 +170,9 @@ def test_test_draft_datasource_config_success_sql_ds(
     assert action_result.created_resources == []
 
     # assert that the action properly calls helper methods to get table names and update the draft config
-    _get_table_names_spy.assert_called_with(datasource=datasource_cls(**datasource_config))
+    _get_table_names_spy.assert_called_with(
+        datasource=datasource_cls(**datasource_config), include_views=True
+    )
     _update_table_names_list_spy.assert_called_with(config_id=config_id, table_names=table_names)
 
 

tests/agent/actions/test_list_table_names_action.py

@@ -105,8 +105,10 @@ def test_run_list_table_names_action_returns_action_result(
     )
 
     table_names = ["table_1", "table_2", "table_3"]
+    view_names = ["view_1", "view_2"]
     inspector = mocker.Mock(spec=Inspector)
     inspector.get_table_names.return_value = table_names
+    inspector.get_view_names.return_value = view_names
 
     mock_inspect.return_value = inspector
 

tests/integration/actions/test_draft_datasource_config_action.py

@@ -72,6 +72,7 @@ def test_running_draft_datasource_config_action(
         "organization_users",
         "validations",
         "api_tokens",
+        "pg_stat_statements",  # view
     ]
     # add spies to the action methods
     _get_table_names_spy = mocker.spy(action, "_get_table_names")

tests/integration/actions/test_list_table_names.py

@@ -69,6 +69,7 @@ def test_running_list_table_names_action(
         "organization_users",
         "user_asset_alerts",
         "validations",
+        "pg_stat_statements",
     ]
 
     # add spy to the action method