Pre-bind sockets on creation #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When sending a datagram, non-bound sockets require a DNS lookup. Instead, bind the socket to the given addresses when creating the socket. Also, lazily create the socket connections, which allows the notify methods to capture the exceptions as expected. If the sockets are created and bound at initialize, an exception would occur then. Lastly, allow resetting the connections if the addresses are changed. Fixes graylog-labs#31
| # Get UDPSockets that are prebound to the given addresses | ||
| def sockets | ||
| @sockets ||= addresses.map do |address| | ||
| host, port = address |
There was a problem hiding this comment.
I think you don't need this, you could try:
sockets ||= addresses.map do |host, port|
socket = UDPSocket.new
socket.connect(host, port)
socket
end
|
Both of these concerns are valid and would be fixed, however, I don't think this will be merged in. See #31 (comment) |
|
I'm closing this since I don't believe this is the right technique because it's not safe for networks that allows the Graylog server to change IP addresses. If you believe I'm wrong, please re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sending a datagram, non-bound sockets require a DNS lookup.
Instead, bind the socket to the given addresses when creating the
socket.
Also, lazily create the socket connections, which allows the
notify methods to capture the exceptions as expected. If the sockets
are created and bound at initialize, an exception would occur then.
Lastly, allow resetting the connections if the addresses are changed.
Fixes #31