Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(design): add link mode to tabs component #3429

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #3425

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@griest024 griest024 added the package: design @daffodil/design label Jan 14, 2025
@griest024 griest024 requested a review from xelaint January 14, 2025 00:38
@griest024 griest024 requested a review from a team as a code owner January 14, 2025 00:38
Comment on lines 4 to 7

a {
text-decoration: none;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xelaint I can't get this to remove the underline from the tabs, can you fix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@griest024
Copy link
Member Author

@xelaint #3377 is a good acceptance test for this if you want a real world use case

@xelaint
Copy link
Member

xelaint commented Jan 14, 2025

@griest024 can you add docs to the markdown about linkMode?

@griest024
Copy link
Member Author

@griest024 can you add docs to the markdown about linkMode?

done

@griest024 griest024 merged commit 69d2859 into graycoreio:develop Jan 14, 2025
13 checks passed
@griest024 griest024 deleted the feat/design/tabs/link-mode branch January 15, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: design @daffodil/design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Implement link mode for tabs
2 participants