Skip to content

Commit

Permalink
feat(design): deprecate embolden mixin and class
Browse files Browse the repository at this point in the history
  • Loading branch information
@xelaint
xelaint committed Jan 9, 2025
1 parent 203f7e0 commit 2c74c6b
Show file tree
Hide file tree
Showing 43 changed files with 61 additions and 55 deletions.
2 changes: 1 addition & 1 deletion ...o/src/app/content/why-pwa/components/feature-comparison/feature-comparison.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@

&__header {
@include comparison-cell();
@include daff.embolden();
align-items: flex-start;
font-size: 0.75rem;
font-weight: bold;
padding: 15px 5px;
text-transform: uppercase;

Expand Down
2 changes: 1 addition & 1 deletion ...affio/src/app/content/why-pwa/components/why-pwa-overview/why-pwa-overview.component.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
A new level of quality to help scale your business
</div>
<p daffCalloutSubtitle>
Progressive Web Apps are the future to offering <span class="embolden">fast, integrated, reliable, and engaging</span> mobile shopping experiences.
Progressive Web Apps are the future to offering <strong>fast, integrated, reliable, and engaging</strong> mobile shopping experiences.
</p>
<div daffCalloutBody class="daffio-why-pwa-overview__card-grid">
<daff-card>
Expand Down
2 changes: 1 addition & 1 deletion apps/daffio/src/app/core/footer/footer/footer.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,10 +66,10 @@
}

&__link {
@include daff.embolden();
display: flex;
align-items: center;
gap: 8px;
font-weight: bold;
text-decoration: none;
text-transform: uppercase;
}
Expand Down
2 changes: 1 addition & 1 deletion apps/daffio/src/app/docs/components/table-of-contents/table-of-contents.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
top: calc(var(--daff-sidebar-side-fixed-top-shift) + 96px);

&__title {
@include daff.embolden();
font-weight: bold;
margin: 0 0 24px;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/daffio/src/app/newsletter/newsletter.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@

.daffio-newsletter {
&__header {
@include daff.embolden();
text-transform: uppercase;
font-size: 1rem;
font-weight: bold;
padding: 0 0 24px;
text-transform: uppercase;
}

&__content {
Expand Down
2 changes: 1 addition & 1 deletion ...-notification/components/add-to-cart-notification/add-to-cart-notification.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
}

&__header {
@include embolden();
font-weight: bold;
margin-bottom: 25px;
text-transform: uppercase;
}
Expand Down
4 changes: 2 additions & 2 deletions ...components/add-to-cart-notification/components/product-added/product-added.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,10 @@
}

&__name {
@include clickable();
font-size: $medium-font-size;
font-weight: bold;
margin-bottom: 5px;
@include embolden();
@include clickable();
}

&__price {
Expand Down
4 changes: 2 additions & 2 deletions apps/demo/src/app/cart/components/cart-item/cart-item.component.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
<div class="demo-cart-item__name" (click)="redirectToProduct()">{{item.name}}</div>
<div class="demo-cart-item__price">${{item.price}}</div>
<div class="demo-cart-item__attribute">
<span class="embolden">Color: </span><span>White (HC)</span><br>
<span class="demo-cart-item__attribute-label">Color: </span><span>White (HC)</span><br>
</div>
<div class="demo-cart-item__size">
<span class="embolden">Size: </span><span>5 (HC)</span><br>
<span class="demo-cart-item__attribute-label">Size: </span><span>5 (HC)</span><br>
</div>
<div class="demo-cart-item__qty-wrapper">
<span class="demo-cart-item__mobile-qty">Qty: </span>
Expand Down
8 changes: 6 additions & 2 deletions apps/demo/src/app/cart/components/cart-item/cart-item.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
&__name {
cursor: pointer;
font-size: 1rem;
@include embolden();
font-weight: bold;

@include breakpoint(big-tablet) {
margin-bottom: 15px;
Expand All @@ -40,7 +40,7 @@

&__mobile-qty {
display: inline;
@include embolden();
font-weight: bold;

@include breakpoint(big-tablet) {
display: none;
Expand Down Expand Up @@ -90,6 +90,10 @@
grid-area: attribute;
}

&__attribute-label {
font-weight: bold;
}

&__size {
grid-area: size;
}
Expand Down
2 changes: 1 addition & 1 deletion apps/demo/src/app/cart/components/cart-sidebar/cart-sidebar.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
}

&__title {
@include embolden();
font-weight: bold;
display: none;
text-transform: uppercase;

Expand Down
2 changes: 1 addition & 1 deletion apps/demo/src/app/cart/components/cart-summary/cart-summary.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
}

&__title {
@include embolden();
font-weight: bold;
}

&__minicart {
Expand Down
2 changes: 1 addition & 1 deletion apps/demo/src/app/cart/components/cart-totals-item/cart-totals-item.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
}

&.emphasize { /* stylelint-disable-line selector-class-pattern */
@include embolden();
font-weight: bold;
text-transform: uppercase;
}
}
2 changes: 1 addition & 1 deletion apps/demo/src/app/cart/components/cart/cart.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
}

&__title {
@include embolden();
font-weight: bold;
text-transform: uppercase;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/demo/src/app/cart/components/minicart-item/minicart-item.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@
}

&__name {
@include embolden();
@include clickable();
font-weight: bold;
}

&__price {
Expand Down
2 changes: 1 addition & 1 deletion apps/demo/src/app/checkout/components/payment/billing-summary/billing-summary.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
font-size: $small-font-size;

&__title {
@include embolden();
font-weight: bold;
margin: 15px 0 5px;
}
}
4 changes: 2 additions & 2 deletions apps/demo/src/app/checkout/components/payment/payment-form/payment-form.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@
}

&__title {
@include embolden();
font-weight: bold;
margin-bottom: 15px;
text-transform: uppercase;
}

&__subtitle {
@include embolden();
font-weight: bold;
margin-bottom: 15px;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/demo/src/app/checkout/components/payment/payment-summary/payment-summary.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,14 @@

&__title {
grid-area: title;
@include embolden();
font-size: 1rem;
font-weight: bold;
margin-bottom: 15px;
text-transform: uppercase;
}

&__method-title {
@include embolden();
font-weight: bold;
grid-area: method-title;
}

Expand Down
2 changes: 1 addition & 1 deletion ...mo/src/app/checkout/components/shipping-address/form/shipping-address-form.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
flex-direction: column;

&__title {
@include embolden();
font-weight: bold;
margin-bottom: 15px;
text-transform: uppercase;
}
Expand Down
6 changes: 3 additions & 3 deletions .../app/checkout/components/shipping-address/summary/shipping-address-summary.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
}

&__title {
@include embolden();
font-size: 1rem;
font-weight: bold;
margin-bottom: 15px;
text-transform: uppercase;
grid-area: title;
Expand All @@ -47,9 +47,9 @@
}

&__subtitle {
margin: 15px 0 5px;
@include embolden();
grid-area: subtitle;
font-weight: bold;
margin: 15px 0 5px;
}

&__shipping-option {
Expand Down
2 changes: 1 addition & 1 deletion apps/demo/src/app/checkout/components/shipping/shipping-form/shipping-form.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
flex-direction: column;

&__title {
@include embolden();
font-weight: bold;
margin-bottom: 15px;
text-transform: uppercase;
}
Expand Down
2 changes: 1 addition & 1 deletion ...nts/shipping/shipping-options/components/shipping-options/shipping-options.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
}

legend {
@include embolden();
font-weight: bold;
font-size: 1rem;
margin-right: 15px;
}
Expand Down
4 changes: 2 additions & 2 deletions ...emo/src/app/checkout/components/shipping/shipping-summary/shipping-summary.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
}

&__title {
@include embolden();
font-size: 1rem;
font-weight: bold;
margin-bottom: 15px;
text-transform: uppercase;
grid-area: title;
Expand All @@ -48,7 +48,7 @@

&__subtitle {
margin: 15px 0 5px;
@include embolden();
font-weight: bold;
grid-area: subtitle;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/demo/src/app/misc/help-box/help-box.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
padding: 25px;

&__title {
@include embolden();
font-weight: bold;
margin-bottom: 15px;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/demo/src/app/misc/not-found/not-found.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
}

&__text {
@include embolden();
font-weight: bold;
margin-bottom: 50px;
text-align: center;
text-transform: uppercase;
Expand Down
2 changes: 1 addition & 1 deletion apps/demo/src/app/newsletter/newsletter.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
}

&__title {
@include embolden();
font-weight: bold;
font-size: 1.5rem;
margin: 0;
padding-bottom: 15px;
Expand Down
2 changes: 1 addition & 1 deletion apps/demo/src/app/product/components/product-card/product-card.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
}

&__brand {
@include embolden();
font-weight: bold;
text-transform: uppercase;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/demo/src/app/product/components/product/product.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@
}

&__name {
@include embolden();
font-size: $large-font-size;
font-weight: bold;
padding: 5px 0;
}

Expand Down
2 changes: 1 addition & 1 deletion apps/demo/src/app/product/containers/best-sellers/best-sellers.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

.demo-best-sellers {
&__title {
@include embolden();
font-weight: bold;
font-size: $medium-font-size;
margin-bottom: 30px;
text-align: center;
Expand Down
4 changes: 2 additions & 2 deletions apps/demo/src/app/thank-you/components/thank-you/thank-you.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
}

&__title {
@include embolden();
font-weight: bold;
text-transform: uppercase;
}

&__body {
margin: 25px 0 50px;

span {
@include embolden();
font-weight: bold;
}
}
}
2 changes: 1 addition & 1 deletion apps/design-land/src/app/navbar/navbar.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
justify-content: space-between;

&__link {
@include embolden();
font-weight: bold;
font-size: 1.125rem;
padding: 0 15px;
text-decoration: none;
Expand Down
2 changes: 1 addition & 1 deletion libs/design/article/src/article/article.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
}

strong {
@include t.embolden;
font-weight: bold;
}

pre {
Expand Down
2 changes: 1 addition & 1 deletion libs/design/callout/src/callout/callout.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
}

&__title {
@include t.embolden;
font-size: 1.75rem;
font-weight: bold;
line-height: 2rem;
margin: 0;
max-width: 1040px;
Expand Down
1 change: 0 additions & 1 deletion libs/design/guides/foundations/typography.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ The headline mixins are responsive and will adjust at the `tablet` breakpoint.

| Class/Mixin | Description |
| ------------- | ---------------------------------------------------------------------------- |
| embolden | Changes the weight of text to 700 |
| uppercase | Changes the casing of a piece of text to uppercase |
| text-truncate | Forces a line of text to ellipsis once it reaches the width of its container |

Expand Down
2 changes: 1 addition & 1 deletion libs/design/hero/src/hero/hero.component.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
}

&__title {
@include t.embolden;
font-size: 2.5rem;
font-weight: bold;
line-height: 2.5rem;
margin: 0;
max-width: 1040px;
Expand Down
Loading

0 comments on commit 2c74c6b

Please sign in to comment.