Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure join method - use subscription ID from attested data #48707

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

atburke
Copy link
Contributor

@atburke atburke commented Nov 8, 2024

This change updates the Azure join method to lookup VMs based on the subscription ID provided in the VM's attested data, rather than the subscription ID derived from its access token. This allows Azure VMs to join a cluster even if their managed identity is from a different subscription than the VM itself.

Changelog: Allow Azure VMs to join from a different subscription than their managed identity

@bl-nero
Copy link
Contributor

bl-nero commented Nov 8, 2024

@atburke I don't feel too confident reviewing this PR, since I don't understand the security implications of this one. Is there an RFD somewhere? Can you get someone who is more familiar with this area? My main concern is that I don't understand what "a different subscription than the VM itself" means, and what kind of attack vectors it opens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants