Restore S3 FIPS and custom endpoint capabilities #48684
Open
+228
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
the
no-changelog
rosstimothy
commented
Nov 8, 2024
Comment on lines
-37
to
-40
| func TestMain(m *testing.M) { | ||
| utils.InitLoggerForTests() | ||
| os.Exit(m.Run()) | ||
| } |
There was a problem hiding this comment.
This is removed because it's already defined in the package. This went unnoticed because this file is gated by a build tag is not often ran 😢.
rosstimothy
force-pushed
the
tross/s3_fips
branch
2 times, most recently
from
3fc7673
to
7bdba16
Compare
When migrating the S3 events handler to use aws-sdk-go-v2 applying the FIPS settings and custom endpoint were inadvertently dropped. This restores the functionality, while also adding tests to ensure that they are always respected going forward. A similar test was added to the dynamodb events handler as well to prevent any regressions with FIPS settings there.
rosstimothy
force-pushed
the
tross/s3_fips
branch
from
7bdba16
to
a169a8d
Compare
r0mant
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When migrating the S3 events handler to use aws-sdk-go-v2 applying the FIPS settings and custom endpoint were inadvertently dropped. This restores the functionality, while also adding tests to ensure that they are always respected going forward.
A similar test was added to the dynamodb events handler as well to prevent any regressions with FIPS settings there.