SSO MFA - fail gracefully when the Proxy is down #48641
Open
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
approved these changes
Nov 8, 2024
| return nil, trace.Wrap(err, "failed to handle SSO MFA ceremony") | ||
| // We may fail to start the SSO MFA flow in cases where the Proxy is down or broken. Fall | ||
| // back to skipping SSO MFA, especially since SSO MFA may not even be allowed on the server. | ||
| slog.DebugContext(ctx, "Failed to attempt SSO MFA, continuing with other MFA methods.", "error", err) |
There was a problem hiding this comment.
Suggested change
| slog.DebugContext(ctx, "Failed to attempt SSO MFA, continuing with other MFA methods.", "error", err) | |
| slog.DebugContext(ctx, "Failed to attempt SSO MFA, continuing with other MFA methods", "error", err) |
From rfd154
- The message should be a fragment, and not a full sentence. Terminating the message with punctuation should be avoided.
rosstimothy
approved these changes
Nov 8, 2024
public-teleport-github-review-bot
bot
removed request for
tcsc and
probakowski
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow SSO MFA to fail gracefully on the client when the Proxy is down. The SSO MFA ceremony construct fails because it can't create the redirector flow without the proxy addr.
Fixes #48633