Using discovery service poll_interval for access graph sync #48556
+441
−368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
reviewed
Nov 6, 2024
ryanclark
reviewed
Nov 7, 2024
mvbrock
force-pushed
the
mvbrock/access-graph-poll-interval
branch
from
f3ae8f0
to
0f8dd6a
Compare
tigrato
reviewed
Nov 8, 2024
Co-authored-by: Tiago Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bpdohall noticed that the Access Graph was flooding the AWS IAM API with 200K+ requests per day. We decided per our converstaion that the best approach is to just allow for poll interval configurability.
Changelog: The access graph poll interval is now configurable with the
discovery_service.poll_intervalfield, whereas before it was fixed to a 15 minute interval.