-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GA4 Tracking events #457
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something might be tangled in the recent PRs. they all have this same engaged code instead of only the pixel code. Could you take a look?
Yes this is on purpose. For convenience I based these tracking PRs off the Initial GTM Migrations branch as they all use the same logic for tracking their respective engaged view events. In hindsight probably a bad move but that PR will be merged before these other tracking event PRs so I don't imagine there will be issues. |
Ah ok, no worries. In the future, if you open the PR against the branch that another PR is open for, when that base branch merges, all the other PRs automatically get rebased to master. Makes it easier on you! |
Changes
Next PR: https://github.com/gravitational/next/pull/2479
Blog PR: https://github.com/gravitational/blog/pull/532
Merge checklist
Testing Checklist