-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Request<T>
where T
is a type that implements hyper::body::Body
trait
#1263
Conversation
Request<T>
where T
is a type that implements hyper::body::Body
trait
CI Checks seem to fail and this is weird since the issues arise from the Any pointers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR, sorry for the slow response! Are there backward compat considerations here? I see you have a default type but I am not sure. Also, can you add a test so we can be sure this doesn't regress?
Thanks for checking in. To answer your concerns..
Yes, this PR is fully backward compatible. How do we know? There's a test already included here and it passes with no need for further configuration.
Yes I can add a test for custom |
@elcharitas @LegNeato I'll look into it too in the next few working days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elcharitas I've somewhat relaxed trait bounds. Anything else seems fine. Thanks! 🍻
Should resolve #1102