Fix: Handle errors caused by presence of charset in blob types #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the change, a blob type containing a MIME type with the `charset` set could cause a breaking error. This commit addresses the issue. It might be an imperfect solution since there might be other charsets, and the `blob.text()` function always assumes UTF-8. However, the alternative would be usage of the `FileReader.readAsText()` which will require additional changes, as the latter uses callbacks instead of promises, and it might be deprecated later due to this. The possibility of using another encoding is negligible. Moreover, support for it might be introduced later in case someone reports a problem.
|
@LunaticMuch @IvanGoncharov I would appreciate if you can find a few minutes to review the PR. |
|
@LunaticMuch @IvanGoncharov it would be amazing if you can find a couple of minutes to review this PR :) We are trying to clear a backlog in our tool and we have an issue that is likely caused by the problem that this PR fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commit message
P.S. charset could be extracted with this regex
/charset\s*=\s*"?([^()<>@,;:\\\"/[\]?.=\s]*)"?/ifixes #387