Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalid serialization of CheckHealthError #565

Merged
merged 1 commit into from
Jan 2, 2025
Merged

fix: invalid serialization of CheckHealthError #565

merged 1 commit into from
Jan 2, 2025

Conversation

Theodus
Copy link
Member

@Theodus Theodus commented Jan 2, 2025

This fixes a response payload previously using an error field, which is invalid for GraphQL over HTTP.

@coveralls
Copy link

coveralls commented Jan 2, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12584156542

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 77.627%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/service/src/routes/health.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 12583903806: 0.08%
Covered Lines: 6804
Relevant Lines: 8765
💛 - Coveralls

@Theodus Theodus enabled auto-merge (squash) January 2, 2025 14:44
@Theodus Theodus disabled auto-merge January 2, 2025 14:45
@Theodus Theodus merged commit 73fdc95 into main Jan 2, 2025
10 checks passed
@Theodus Theodus deleted the theodus/errors branch January 2, 2025 15:52
@github-actions github-actions bot mentioned this pull request Jan 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Theodus @coveralls @gusinacio