Update rewrite-rules.conf.example - explicitly state aggregator #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly state and relate rewrite-rules.conf to carbon-aggregator so that this info is available to the user in-situ in the example. There is ambiguity in the phrase "as soon as they are received" this can confusing because carbon-relay could be seen as where they are being received. Related to graphite-project/graphite-web#2845 which tries to make it clearer in the docs as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly state and relate rewrite-rules.conf to carbon-aggregator so that this info is available to the user in-situ in the example. There is ambiguity in the phrase "as soon as they are received" this can confusing because carbon-relay could be seen as where they are being received.
Related to graphite-project/graphite-web#2845 which tries to make it clearer in the docs as well.