-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not zoom if marker was dragged #193
Conversation
I agree that we need something like this. I could imaginge that one wants an enum of map behaviour at some point. But this can be refactored later. From my side this can be merged. |
Cool, thanks! This fixed #163, right? Makes drawing markers a lot more enjoyable for sure :) Putting the |
To be honest I do not know how to implement it properly. For RoutingArgs you are probably right that this does not belong there and I can have a look if I can move it out. But for QueryStoreState we could say that this zoom property (if "zooming to the query result" is enabled) should we stored there. Not sure. |
I had the same thought, but then I didn't have another idea quickly. Since we all don't feel good about this we could think of a better way to do this, or at least remember it for the next UI related property and do it then. |
Ok, good idea. I added a todo comment here: e95f88e The zoom property is like a parameter that describes the UI behavior, but then it is also only 'valid' for a specific request: When dragging the marker it is set to false for the next request, but when we type two cities in the query boxes directly it should be true for the next request... |
* do not zoom if marker was dragged * formatting
The current behaviour is pretty annoying and so I disabled this, in this PR.
(not sure if this is the proper way to do this or if we should have the zoom parameter e.g. in SetPoint)
Related to #177