[bug] Use stack string in UUID generation

This triggered a bug on Windows on freeing the string. Removing the heap allocation fixed the bug, so I didn't look further.
grandchild · Jan 1, 2025 · 71acf34 · 71acf34
1 parent 433c092
commit 71acf34
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/avs/uuid.cpp b/avs/uuid.cpp
@@ -7,7 +7,7 @@
 #endif
 
 std::string uuid4() {
-    auto uuid_str = (char*)malloc(37);
+    char uuid_str[37];
     uuid_str[36] = '\0';
 #ifdef _WIN32
     UUID uuid;
@@ -18,7 +18,5 @@ std::string uuid4() {
     uuid_generate(uuid);
     uuid_unparse_lower(uuid, uuid_str);
 #endif
-    auto retval = std::string(uuid_str);
-    free(uuid_str);
-    return retval;
+    return uuid_str;
 }