Improved Descendant Tree - resubmit with new fixes #1873
Conversation
new Descendtree.py was based on recently outdated code. Just re-applied changes to the new version.
|
This PR should have been named "Improved Descend Tree". It is my mistake. Please let me know when I can create another PR for a similar Tree (Ancestor Tree) that depends on the new gen/plug/report/utils.py pushed by this PR #1873. |
|
To help explain the nature of the PR, let me share the test results: test_descend_chart_withcolor.pdf |
dave-khuon
changed the title
|
You should implement colour options in the same way as the graph reports. Perhaps it is time to create a standard option for this? |
|
In the beginning, I was thinking of doing that too. I wanted to implement a common function in report/utils.py. However, due to the way this Tree Chart uses box styles, I was not able to dynamically modify the box color for each person's gender. To make it work, I end up creating a set of 2 boxes for each gender (normal and bolded) at the outset. There are other graph reports based on graphviz that seem to be able do that. Their names are specific to each report. Maybe there are other ways. I am open to suggestions, to learn more about how the boxes work. PS: I may also handle the creation and switching of the personbox names in a function in utils.py. I feel that in doing so, I am putting a distance between the report and its person boxes. Ideally, I would like to get some help if we can dynamically modify the box color as we navigate along the tree. |
Hi Nick, I refactored the creation and invocation of styles by gender and family boxes to the utils class. I am still using style sheets to control the box color. Is it possible to consider this as a stop-gap solution, for the time being? I am also looking at using graph reports such as family-line and hour-glass. It would be a major rewrite, in my estimation. I like their extra capability, and I am thinking of creating graph-based reports for ancestors and descendants that allow "scale to fit page width only", which is important for me, considering the huge number of nodes for my family. But this is going to take a lot of research and coding. I am not confident that I can do it on my own.
Fix list declaration
|
Hi Nick, Please review my note on "Re-submit after refactoring" about a stop-gap solution. |
new Descendtree.py was based on recently outdated code. Just re-applied changes to the new version.