-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the standard search bar to the SelectPerson dialog #1865
base: master
Are you sure you want to change the base?
Add the standard search bar to the SelectPerson dialog #1865
Conversation
This is draft, pending user feedback from the forum. See the post Adding Search Bar to Select Person Dialog |
0a4df7f
to
a95d922
Compare
Requires PR #1869 to be merged first |
This is now ready for review. The user can click Clear to remove the default filter. All people are then shown. This allows the "Show All" toggle to be removed. This was in part made possible by using the search bar filter instead of Using FastMaleFilter: 5 runs Using search bar filter: 5 runs |
5017ef4
to
c5297fb
Compare
This looks like a better approach. |
The bug fix part of #1865 has been combined into this PR |
When the user specifies a filter in the search bar, use this in preference to the default filter.
… classes In testing, performance was observed to be very similar From a usability point of view, it is now clear to the user what, if any, filter is applied. The user can click the Clear button to remove the filter. This allows the Show All toggle to be removed.
6504604
to
ac267fd
Compare
Rebased. |
Add the standard search bar to the SelectPerson dialog