Parents and spouse labels in relationship view #1843
Conversation
|
Bug #13554 |
|
@Nick-Hall The linked bug is actually a feature request: Have the Parent and Spouse labels dynamically change based upon genders and legal status of marriage don't they go in master? |
|
Yes, implementing a feature request would usually be regarded as an enhancement and should be in the master branch. |
|
@wroldwiedbwe Related discussion As per nick yes, also has implication on documentation for 5.2.x as you'd have older versions in same series showing something different from the user manual if 5.2.x was changed not something anybody wants! |
|
Also as per @DaveSch-gramps on the forum he mentions "Not sure how to make labels say “Stepfather”, “Stepmother”" So probably needs a bit more work and testing before being accepted on gramps/master? |
|
Do I close this PR so that I can rebuild the branch on master ?? or is there a way to move it. |
Nick-Hall
force-pushed
the
Parents-and-Spouse-labels
branch
from
336e7b1 to
f08fad4
Compare
|
Rebased onto the master branch. |
| if father == Person.MALE: | ||
| parent1 = _("Father") | ||
| elif father == Person.FEMALE: | ||
| parent1 = _("Mother") | ||
| else: | ||
| parent1 = _("Parent") |
There was a problem hiding this comment.
Consider moving this block into a function to avoid duplication.
Something like this:
parent1 = self.__get_parent_label(father)
parent2 = self.__get_parent_label(mother)
There was a problem hiding this comment.
Admittedly, I am not a coder. I can hack what others have thought up.
The process I have is to determine the label for the person slotted in the Father/Parent1 slot based upon their gender and then do the same for the person in the Mather/Parent2 slot.
Using my code, I actually have a Female in the F/P1 slot and the father/sperm donor in the M/P2 slot.\ for the labels Mother and Father.
Nick-Hall
changed the title
Have the labels for Father, Mother, Parent set for the active person regardless of the gender of the person set in the Families' Father/Parent1, Mother/Parent2 position.
Have the the labels for Husband, Wife, Spouse, Partner display for families depending on the gender of the spouse. Husband, Wife, Spouse are used for 'legal' marriages (Married, Civil Union) and Partner for non-legal status.