Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge sitemesh3 grails plugin into grails-gsp #562

Open
wants to merge 122 commits into
base: 7.0.x
Choose a base branch
from
Open

Merge sitemesh3 grails plugin into grails-gsp #562

wants to merge 122 commits into from
+43,708 −455

Conversation

jdaugherty
Copy link
Contributor

grails/grails-core#13552

Merges the sitemesh3 grails plugin written by @codeconsole that replaced the sitemesh2 plugin.

When comparing this PR, look at the last commit only to make it easier to check.

A significant amount of rework went into this PR:

  • split sitemesh plugin & example application
  • adopt plugin configuration similar to grails gsp-plugin
  • add tests for sitemesh example application
  • fix API docs for classes not hosted in this project (see PageRenderer -> ApplicationContext)
  • simplify documentation generation
  • repackage org.sitemesh.grails.plugins to org.grails.plugins
  • adopt grails-bom
  • remove common-build usage
  • various doc cleanup after simplification
  • update minimum grails version in gsp plugin
  • composite build switch
  • adopt newer gradle features such as source jars, project.layout, moving away from ant, etc
  • update for grails-gradle plugin features in 7.0
  • remove unneeded, repeated documentation scopes

codeconsole added 30 commits July 26, 2023 17:26
@codeconsole
Initial commit
15adc2e
@codeconsole
grails create-web-plugin org.sitemesh.grails.plugins.sitemesh3.sitemesh3
d1b9713
@codeconsole
Initial plugin.
459c767
@codeconsole
Create demo
5ac65f4
@codeconsole
Update README.md
539e8b4
@codeconsole
Simplify configuration by taking advantage of the layoutViewResolver …
2ddb1fe 
…provided by GroovyPagesGrailsPlugin.
@codeconsole
Use same <meta name=layout content=.../> convention as Grails
2d696f0
@codeconsole
Link to Grails SiteMesh 3 issue
cd6e54c
@codeconsole
Body tag id/class/style merging.
708dca6
@codeconsole
Allow publishToMavenLocal
ae83e8d
@codeconsole
remove unused mapping
1fa6914
@codeconsole
Filter must be ordered before grailsWebRequestFilter.
dee5454
@codeconsole
Use path prefixes, use layout meta tag and support current version of…
44fafee 
… grails and grails once sitemesh has been decoupled.
@codeconsole
Update README.md - Installation instructions
e8e5fef
@codeconsole
Force grails.gsp.view.layoutViewResolver = true
0c55724
@codeconsole
Update README.md simplified installation
5c9b74f
@codeconsole
Update README.md add pull references
1a6fd53
@codeconsole
Register TagLibs last so the override any existing ones in classpath
a8e46c7
@codeconsole
Remove comments
fd9a8c3
@codeconsole
Remove jsp fix code.
44d6a71
@codeconsole
Remove unused imports
590d336
@codeconsole
Remove unnecessary comments.
c5b8d5c
@codeconsole
Fix formatting
664e7c7
@codeconsole
Update README.md remove obvious comments
14458c8
@codeconsole
Update README.md grammar
21b2e13
@codeconsole
JSP demo. Revert 6.0.1-SNAPSHOT dependency.
eaf1906
@codeconsole
Change plugin to use spring-boot-starter-sitemesh
9fcde6d
@codeconsole
Revert rte if sitemesh 2 lib is installed.
f17ecb4
@codeconsole
Tag lib loading order no longer important as conflicting tags are now…
eb4402e 
… excluded.
@codeconsole
Remove need for opensymphony:sitemesh and org.grails:grails-web-sitemesh
67e5bf3
codeconsole and others added 24 commits November 11, 2024 11:27
@jdaugherty jdaugherty mentioned this pull request Jan 11, 2025
Open
@jdaugherty
Project clean up
a0ffa1a 
* split sitemesh plugin & example application
* add tests for sitemesh example application
* fix API docs for classes not hosted in this project (see PageRenderer -> ApplicationContext)
* repackage org.sitemesh.grails.plugins to org.grails.plugins
* adopt grails-bom
* remove common-build usage
* doc cleanup
* update minimum grails version
* composite build switch
* simplified docs build
* adopt newer gradle features such as source jars, project.layout, moving away from ant, etc
* update for grails-gradle plugin features in 7.0
* remove unneeded documentation scope
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeconsole codeconsole Awaiting requested review from codeconsole

@matrei matrei Awaiting requested review from matrei

@jamesfredley jamesfredley Awaiting requested review from jamesfredley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdaugherty @codeconsole