readd session token to s3 credentials #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farodin91
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
3 tasks
|
Thanks for catching and fixing this. Can you add a changelog entry? |
Signed-off-by: Jan Jansen <[email protected]>
farodin91
force-pushed
the
readd-session-token-to-s3-credentials
branch
from
b3e63d9
to
47fbdd6
Compare
|
changelog added |
joe-elliott
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Looks good! Thanks for the fix. Do you need this backported to use 2.3?
cc @mapno
|
@joe-elliott Would be nice. |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3144-to-release-v2.3 origin/release-v2.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 3008ee5c610129fb16bce408fa17b39c26cf5b5fWhen the conflicts are resolved, stage and commit the changes: If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3144-to-release-v2.3
# Create the PR body template
PR_BODY=$(gh pr view 3144 --json body --template 'Backport 3008ee5c610129fb16bce408fa17b39c26cf5b5f from #3144{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title "[release-v2.3] readd session token to s3 credentials" --body-file - --label "type/bug" --label "backport" --base release-v2.3 --milestone release-v2.3 --webOr, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3144-to-release-v2.3
# Create a pull request where the `base` branch is `release-v2.3` and the `compare`/`head` branch is `backport-3144-to-release-v2.3`.
# Remove the local backport branch
git switch main
git branch -D backport-3144-to-release-v2.3 |
joe-elliott
pushed a commit
that referenced
this pull request
Nov 27, 2023
Signed-off-by: Jan Jansen <[email protected]> (cherry picked from commit 3008ee5)
3 tasks
joe-elliott
added a commit
that referenced
this pull request
Nov 27, 2023
Signed-off-by: Jan Jansen <[email protected]> (cherry picked from commit 3008ee5) Co-authored-by: Jan Jansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Support was removed in #3006
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]