Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGE] Switch protocol for internal traces from Jaeger to OTLP/HTTP #1103

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andreasgerstmayr
Copy link
Collaborator

Tempo switched to OTLP export in 2.7: https://github.com/grafana/tempo/releases/tag/v2.7.0
gateway switched to OTLP/HTTP in observatorium/api#768

This PR updates the operator to enable the correct flags/env variables.

…OTLP/HTTP

Exporting internal traces (traces generated by Tempo and the gateway) via the Jaeger/Thrift protocol
and the `.spec.observability.tracing.jaeger_agent_endpoint` setting is deprecated.
Please migrate to the OTLP/HTTP protocol and the new `.spec.observability.tracing.otlp_http_endpoint` setting.

Signed-off-by: Andreas Gerstmayr <[email protected]>
@andreasgerstmayr andreasgerstmayr force-pushed the internal-tracing-otlp-http branch from 190fbd0 to ab8d3a3 Compare January 24, 2025 16:21
Signed-off-by: Andreas Gerstmayr <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 58.53%. Comparing base (988f89a) to head (db7b9c9).

Files with missing lines Patch % Lines
internal/webhooks/tempostack_webhook.go 86.36% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1103      +/-   ##
==========================================
- Coverage   58.59%   58.53%   -0.06%     
==========================================
  Files         113      113              
  Lines       10157    10153       -4     
==========================================
- Hits         5951     5943       -8     
- Misses       3902     3905       +3     
- Partials      304      305       +1     
Flag Coverage Δ
unittests 58.53% <90.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants