-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow using external variables in export and env list #1112
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙂 Makes sense and look good! Can you please just fix that one linting issues?
Co-authored-by: Horst Gutmann <[email protected]>
Thanks for the review! |
Thank you for working on this 🙂 |
Awesome! I've made a fork of tanka that my org is currently using as a workaround so its not like we're hurting, but is there a way to know when when this will be included in a standard release? |
I wanted to cut a new release some time this week if time permits 🙂 |
v0.28.0 is out now 😄 https://github.com/grafana/tanka/releases/tag/v0.28.0 |
Using
std.extVar
in an inline environment's definition will causetk env list
andtk export ... --recursive
to fail.An example use case (what I'm writing this to support), is when you have inline environments whose namespace needs to be set at runtime, such as a review environment whos namespace is dynamic eg:
Tanka has a bunch of different ways one could work around this, but its very convenient to be able to specify the default namespace so succinctly.
tk export ... --recursive
theJsonnetOpts
were already parsed and just needed to be plumbed through to where environments are discovered.tk env list
, theext-str
andtla-str
arguments needed to be added to the command.