Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Group dependency updates #1095

Merged
merged 4 commits into from
Jul 3, 2024
Merged

chore: Group dependency updates #1095

merged 4 commits into from
Jul 3, 2024

Conversation

zerok
Copy link
Contributor

@zerok zerok commented Jul 3, 2024

Dependency updates for supporting code (i.e. docs, dagger, acceptance-tests) should be bundled into a single PR.

This also includes generated code from Dagger so that Dependabot can generate valid PRs for it.

Replaces #1094

Dependency updates for supporting code (i.e. docs, dagger,
acceptance-tests) should be bundled into a single PR.

Replaces #1094
@zerok zerok requested a review from a team July 3, 2024 09:55
Copy link

github-actions bot commented Jul 3, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://grafana.github.io/tanka/pr-preview/pr-1095/
on branch gh-pages at 2024-07-03 09:56 UTC

Copy link
Member

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cheers! seems like the way to go 👍

could you update dagger/README.md? it says to run dagger develop but is that necessary now the files are in there? might be good if that readme described how to update the files anyway 🙂

optional: how about a quick CI job which detects drift? e.g. install a fixed version of dagger, re-vendor, make sure there is no diff.

optional: suggest reverting the changes to go.mod and go.sum, and then we can see if Dependabot will create a correct update after you merge this

@zerok
Copy link
Contributor Author

zerok commented Jul 3, 2024

cheers! seems like the way to go 👍

could you update dagger/README.md? it says to run dagger develop but is that necessary now the files are in there? might be good if that readme described how to update the files anyway 🙂

Totally forgot about that, thanks 🙂 Will do right away.

optional: how about a quick CI job which detects drift? e.g. install a fixed version of dagger, re-vendor, make sure there is no diff.

Will do 🙂

optional: suggest reverting the changes to go.mod and go.sum, and then we can see if Dependabot will create a correct update after you merge this

I think the go.mod file will still be updated in the next dependabot run as the bumps for otel in this PR are to 1.27.x and 0.3.0. Dependabot will see also the option to update to 1.28.0 and 0.4.0 🙂

@zerok zerok force-pushed the zerok/group-dependency-updates branch 7 times, most recently from abda369 to 1780e2d Compare July 3, 2024 12:35
@zerok zerok force-pushed the zerok/group-dependency-updates branch from 1780e2d to 6aabef9 Compare July 3, 2024 12:38
@zerok zerok requested a review from iainlane July 3, 2024 12:43
Copy link
Member

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice

@zerok zerok merged commit f469574 into main Jul 3, 2024
9 checks passed
@zerok zerok deleted the zerok/group-dependency-updates branch July 3, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants