-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Group dependency updates #1095
Conversation
Dependency updates for supporting code (i.e. docs, dagger, acceptance-tests) should be bundled into a single PR. Replaces #1094
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers! seems like the way to go 👍
could you update dagger/README.md
? it says to run dagger develop
but is that necessary now the files are in there? might be good if that readme described how to update the files anyway 🙂
optional: how about a quick CI job which detects drift? e.g. install a fixed version of dagger, re-vendor, make sure there is no diff.
optional: suggest reverting the changes to go.mod
and go.sum
, and then we can see if Dependabot will create a correct update after you merge this
Totally forgot about that, thanks 🙂 Will do right away.
Will do 🙂
I think the go.mod file will still be updated in the next dependabot run as the bumps for otel in this PR are to 1.27.x and 0.3.0. Dependabot will see also the option to update to 1.28.0 and 0.4.0 🙂 |
abda369
to
1780e2d
Compare
1780e2d
to
6aabef9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice
Dependency updates for supporting code (i.e. docs, dagger, acceptance-tests) should be bundled into a single PR.
This also includes generated code from Dagger so that Dependabot can generate valid PRs for it.
Replaces #1094