Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide docs for thanos clients + restore original cli prefix #14545

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

ashwanthgoli
Copy link
Contributor

@ashwanthgoli ashwanthgoli commented Oct 21, 2024

What this PR does / why we need it:

Changes from this pr could result in a change of cli flags for projects relying on the thanos bucket pkg from Loki.

This changes restores a few things listed below:

  • Revert the thanos storage config prefix to default value
  • Register all providers cli flags, same as before
  • Hide thanos storage config in loki docs since not all providers are supported yet

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Oct 21, 2024
@ashwanthgoli ashwanthgoli changed the title chore: hide docs for thanos clients chore: hide docs for thanos clients + restore original cli prefix Oct 21, 2024
@ashwanthgoli ashwanthgoli marked this pull request as ready for review October 21, 2024 07:34
@ashwanthgoli ashwanthgoli requested a review from a team as a code owner October 21, 2024 07:34
@ashwanthgoli ashwanthgoli merged commit b405ae8 into main Oct 21, 2024
63 checks passed
@ashwanthgoli ashwanthgoli deleted the thanos-hide-docs branch October 21, 2024 07:39
sandeepsukhani pushed a commit that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants