Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(querytags): propagate query tags to ingesters #12267

Merged
merged 8 commits into from
Mar 20, 2024
Merged

fix(querytags): propagate query tags to ingesters #12267

merged 8 commits into from
Mar 20, 2024

Conversation

ashwanthgoli
Copy link
Contributor

@ashwanthgoli ashwanthgoli commented Mar 20, 2024 •
edited
Loading

What this PR does / why we need it:
query tags are not being propagated to ingesters because of missing grpc interceptors.
this pr adds interceptors to inject and extract query tags from grpc requests.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@MasslessParticle MasslessParticle marked this pull request as ready for review March 20, 2024 16:52
@MasslessParticle MasslessParticle requested a review from a team as a code owner March 20, 2024 16:52
@MasslessParticle MasslessParticle merged commit ef742c4 into main Mar 20, 2024
12 checks passed
@MasslessParticle MasslessParticle deleted the ingester-query-tags branch March 20, 2024 18:25
edsoncelio pushed a commit to edsoncelio/loki that referenced this pull request Mar 22, 2024
@ashwanthgoli @MasslessParticle @edsoncelio
fix(querytags): propagate query tags to ingesters (grafana#12267)
8a9f8cd 
Co-authored-by: Travis Patterson <[email protected]>
@loki-gh-app loki-gh-app bot mentioned this pull request Mar 27, 2024
Closed
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@ashwanthgoli @MasslessParticle @rhnasc
fix(querytags): propagate query tags to ingesters (grafana#12267)
8d65ede 
Co-authored-by: Travis Patterson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasslessParticle MasslessParticle MasslessParticle approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashwanthgoli @MasslessParticle